Skip to content

fix(doclib): keep image payloads out of search indexes - #5777

Merged
myhloli merged 1 commit into
opendatalab:devfrom
myhloli:dev
Nov 16, 2026
Merged

myhloli merged 1 commit into
opendatalab:devfrom
myhloli:dev

Conversation

@myhloli

@myhloli myhloli commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

Unify image-free index rendering, retain document continuation rules, and migrate legacy indexes from cached parse results with atomic progress and retryable failures.

Require DocVortex 0.6.24 and cover the original issue attachment, migration, and search output regressions.

Refs #5776

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Unify image-free index rendering, retain document continuation rules, and migrate legacy indexes from cached parse results with atomic progress and retryable failures.

Require DocVortex 0.6.24 and cover the original issue attachment, migration, and search output regressions.

Refs opendatalab#5776
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T13:07:13.118179Z 9717845 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@myhloli
myhloli merged commit 1a5c873 into opendatalab:dev Nov 16, 2026
21 of 35 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant